Avoid loading lineitem unnecessarily #16587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
ebyhr
approved these changes
Mar 16, 2023
alexjo2144
approved these changes
Mar 16, 2023
findepi
force-pushed
the
findepi/avoid-loading-unnecessary-test-tables-fa282e
branch
from
05f154a to
f36bcac
Compare
|
Only PTs remaining and these are not affected. Will rebase to resolve conflict and merge. |
|
@nineinchnick would it be possible to skip Iceberg PTs when only Iceberg integration tests are changed, not the connector production code? |
findepi
force-pushed
the
findepi/avoid-loading-unnecessary-test-tables-fa282e
branch
from
2d0a156 to
6b2aaaa
Compare
findepi
deleted the
findepi/avoid-loading-unnecessary-test-tables-fa282e
branch
Not right now. To make product tests conditional, we rely on the list of impacted models produced by GIB. GIB doesn't distinguish changes in tests from regular code. We'd have to find another way to identify impacted modules, or come up with a reason for GIB to make the distinction and possibly contribute that change to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.